bevy_color: Added Xyza Colour Space
#12079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic implementation that will allow other color conversions to be more explicit.
bushrat011899
added
C-Feature
Basic implementation that will allow other color conversions to be more explicit.
…into XYZColorSpace
afonsolage
approved these changes
Feb 24, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective Add XYZ colour space. This will be most useful as a conversion step when working with other (more common) colour spaces. See [Wikipedia](https://en.wikipedia.org/wiki/CIE_1931_color_space) for details on this space. ## Solution - Added `Xyza` to `Color` and as its own type. --- ## Changelog - Added `Xyza` type. - Added `Color::Xyza` variant. ## Migration Guide - `Color` enum now has an additional member, `Xyza`. Convert it to any other type to handle this case in match statements.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective Add XYZ colour space. This will be most useful as a conversion step when working with other (more common) colour spaces. See [Wikipedia](https://en.wikipedia.org/wiki/CIE_1931_color_space) for details on this space. ## Solution - Added `Xyza` to `Color` and as its own type. --- ## Changelog - Added `Xyza` type. - Added `Color::Xyza` variant. ## Migration Guide - `Color` enum now has an additional member, `Xyza`. Convert it to any other type to handle this case in match statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add XYZ colour space. This will be most useful as a conversion step when working with other (more common) colour spaces. See Wikipedia for details on this space.
Solution
XyzatoColorand as its own type.Changelog
Xyzatype.Color::Xyzavariant.Migration Guide
Colorenum now has an additional member,Xyza. Convert it to any other type to handle this case in match statements.