Port bevy_core_pipeline to LinearRgba
#12116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
james7132
approved these changes
Feb 26, 2024
added 2 commits
February 25, 2024 22:44
…i-cecile/bevy into bevy_core_pipeline_colors
bushrat011899
approved these changes
Feb 26, 2024
Comment on lines
+231
to
+240
| impl From<LinearRgba> for wgpu::Color { | ||
| fn from(color: LinearRgba) -> Self { | ||
| wgpu::Color { | ||
| r: color.red as f64, | ||
| g: color.green as f64, | ||
| b: color.blue as f64, | ||
| a: color.alpha as f64, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Since bevy_color is our new color management library specifically for Bevy, would it be worth moving to f64 internally to avoid this casting? The extra precision will eat up more memory, but also expose the full precision of wgpu to end users.
There was a problem hiding this comment.
That's a good question. I think that should be investigated after migration: then we can get both benchmark results and see if there's meaningfully improved color fidelity or numerical stability.
There was a problem hiding this comment.
Probably won't make a big difference on the code-path where wgpu almost immediately casts the color back to a f32 😄
There was a problem hiding this comment.
Well, at this rate I guess we're getting bevy_wgpu
alice-i-cecile
added
the
S-Ready-For-Final-Review
afonsolage
approved these changes
Feb 26, 2024
doonv
approved these changes
Feb 26, 2024
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective - We should move towards a consistent use of the new `bevy_color` crate. - As discussed in bevyengine#12089, splitting this work up into small pieces makes it easier to review. ## Solution - Port all uses of `LegacyColor` in the `bevy_core_pipeline` to `LinearRgba` - `LinearRgba` is the correct type to use for internal rendering types - Added `LinearRgba::BLACK` and `WHITE` (used during migration) - Add `LinearRgba::grey` to more easily construct balanced grey colors (used during migration) - Add a conversion from `LinearRgba` to `wgpu::Color`. The converse was not done at this time, as this is typically a user error. I did not change the field type of the clear color on the cameras: as this is user-facing, this should be done in concert with the other configurable fields. ## Migration Guide `ColorAttachment` now stores a `LinearRgba` color, rather than a Bevy 0.13 `Color`. `set_blend_constant` now takes a `LinearRgba` argument, rather than a Bevy 0.13 `Color`. --------- Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective - We should move towards a consistent use of the new `bevy_color` crate. - As discussed in bevyengine#12089, splitting this work up into small pieces makes it easier to review. ## Solution - Port all uses of `LegacyColor` in the `bevy_core_pipeline` to `LinearRgba` - `LinearRgba` is the correct type to use for internal rendering types - Added `LinearRgba::BLACK` and `WHITE` (used during migration) - Add `LinearRgba::grey` to more easily construct balanced grey colors (used during migration) - Add a conversion from `LinearRgba` to `wgpu::Color`. The converse was not done at this time, as this is typically a user error. I did not change the field type of the clear color on the cameras: as this is user-facing, this should be done in concert with the other configurable fields. ## Migration Guide `ColorAttachment` now stores a `LinearRgba` color, rather than a Bevy 0.13 `Color`. `set_blend_constant` now takes a `LinearRgba` argument, rather than a Bevy 0.13 `Color`. --------- Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_colorcrate.Solution
LegacyColorin thebevy_core_pipelinetoLinearRgbaLinearRgbais the correct type to use for internal rendering typesLinearRgba::BLACKandWHITE(used during migration)LinearRgba::greyto more easily construct balanced grey colors (used during migration)LinearRgbatowgpu::Color. The converse was not done at this time, as this is typically a user error.I did not change the field type of the clear color on the cameras: as this is user-facing, this should be done in concert with the other configurable fields.
Migration Guide
ColorAttachmentnow stores aLinearRgbacolor, rather than a Bevy 0.13Color.set_blend_constantnow takes aLinearRgbaargument, rather than a Bevy 0.13Color.