-
-
Couldn't load subscription status.
- Fork 4.2k
bevy_color: Add sequence_dispersed to Hsla, Lcha, Oklcha
#12173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 8 commits into
bevyengine:main
from
bushrat011899:AddColorFromIndex
Feb 28, 2024
Merged
bevy_color: Add sequence_dispersed to Hsla, Lcha, Oklcha
#12173
alice-i-cecile
merged 8 commits into
bevyengine:main
from
bushrat011899:AddColorFromIndex
Feb 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates deterministic but randomly distributed colors
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
…rator Included link to relevant Wikipedia article for described effect. Implementation reference left as a comment inside the function. Co-Authored-By: Alice Cecile <alice.i.cecile@gmail.com>
bevy_color: Add Hsla::from_index and Lcha::from_index methodsbevy_color: Add sequence_dispersed to Hsla, Lcha, Oklcha
alice-i-cecile
approved these changes
Feb 28, 2024
nicopap
reviewed
Feb 28, 2024
pablo-lua
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified in some kind of trait in the future, but I'm not sure if this is a good idea. But for now, all good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Color
Color spaces and color math
A-Rendering
Drawing game state to the screen
C-Feature
A new feature, making something new possible
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
color_from_indexrandomized color palette generator #12170Solution
color_from_entityinternals intoHsla::sequence_dispersedwhich generates a randomly distributed but deterministic color sequence based.LchaandOklchaas well.Examples
Getting a few colours for a quick palette
Getting a colour from an
EntityNotes
This was previously a private function exclusively for
Entitytypes. I've decided it should instead be public and operate on au32directly, since this function may have broader uses for debugging purposes.