bloom: use emissive instead of base_color for emissive #12220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
C-Bug
afonsolage
approved these changes
Mar 1, 2024
rparrett
approved these changes
Mar 1, 2024
|
This explains a lot of the subtle visual changes after #12163 -- all materials have become slightly emissive! Good catch. |
alice-i-cecile
approved these changes
Mar 1, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
) # Objective - bloom is not working anymore in 3d after bevyengine#12163 ## Solution - Fix a copy paste mistake and use emissive for the emissive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
LegacyColortobevy_color::Color#12163Solution