Move commands module into bevy::ecs::world #12234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
changed the title
alice-i-cecile
added
A-ECS
|
Definitely in favor of this :) Let me know when it's ready to review. |
alice-i-cecile
added
the
M-Needs-Migration-Guide
|
Ready for review. @alice-i-cecile @JoJoJet |
alice-i-cecile
approved these changes
Mar 2, 2024
JoJoJet
approved these changes
Mar 2, 2024
james7132
approved these changes
Mar 2, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
JoJoJet
reviewed
Mar 2, 2024
Comment on lines
-118
to
-125
| impl SystemBuffer for CommandQueue { | ||
| #[inline] | ||
| fn apply(&mut self, _system_meta: &SystemMeta, world: &mut World) { | ||
| #[cfg(feature = "trace")] | ||
| let _span_guard = _system_meta.commands_span.enter(); | ||
| self.apply(world); | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit, but I think it makes sense to keep this impl here, since it's used only for the Commands definition just above
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective Fixes bevyengine#11628 ## Migration Guide `Command` and `CommandQueue` have migrated from `bevy_ecs::system` to `bevy_ecs::world`, so `use bevy_ecs::world::{Command, CommandQueue};` when necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #11628
Migration Guide
CommandandCommandQueuehave migrated frombevy_ecs::systemtobevy_ecs::world, souse bevy_ecs::world::{Command, CommandQueue};when necessary.