Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AssetEvents to Last #12389

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Move AssetEvents to Last #12389

merged 1 commit into from
Mar 9, 2024

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Mar 9, 2024 •
edited
Loading

Objective

Solution

@TrialDragon TrialDragon added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds labels Mar 9, 2024
@james7132 james7132 requested a review from rparrett March 9, 2024 20:55
james7132
james7132 approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this fixes the hang.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 9, 2024
@hymm
Copy link
Contributor Author

hymm commented Mar 9, 2024

LGTM assuming this fixes the hang.

I tested before and after with the command in the linked issue and it worked.

cargo run --release --example bevymark -- --benchmark --waves 130 --per-wave 1000 --mode mesh2d --vary-per-instance

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 9, 2024
@JMS55
Copy link
Contributor

JMS55 commented Mar 9, 2024

Why did this fix things?

Merged via the queue into bevyengine:main with commit 8a08825 Mar 9, 2024
29 checks passed
@hymm hymm deleted the move-asset-events-to-last branch March 10, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

@rparrett rparrett Awaiting requested review from rparrett

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bevymark hangs indefinitely when spawning many unique materials
5 participants
@hymm @JMS55 @james7132 @alice-i-cecile @TrialDragon