Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore lost surface error on exit for xwayland #12687

Closed

Conversation

deltanedas
Copy link

Objective

Hack that stops the panic from #11734 but doesn't fix underlying issue of trying to prepare window after swapchain has been destroyed.

Solution

Just stops trying to configure it and logs it incase the error happens before exiting.

Now it will just log an X error instead of panicking, letting the app clean up properly.

A real fix would be ideal but not sure why it's doing this to begin with.

ERROR winit::platform_impl::platform: X11 error: XError {
    description: "BadWindow (invalid Window parameter)",
    error_code: 3,
    request_code: 146,
    minor_code: 1,
}

Changelog

no cl no fun

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in O-Linux Specific to the Linux desktop operating system A-Rendering Drawing game state to the screen X-Controversial There is active debate or serious implications around merging this PR labels Mar 25, 2024
@alice-i-cecile alice-i-cecile added X-Contentious There are nontrivial implications that should be thought through and removed X-Controversial There is active debate or serious implications around merging this PR labels Aug 16, 2024
Copy link
Contributor

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still an issue given that the linked issue was closed with a different windowing fix? I'd be nervous about merging this without and additional gate around wayland rather than just generically linux.

@deltanedas
Copy link
Author

probably no longer needed, closing

@deltanedas deltanedas closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior O-Linux Specific to the Linux desktop operating system X-Contentious There are nontrivial implications that should be thought through
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants