Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI for wasm atomics #12730

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Fix CI for wasm atomics #12730

merged 2 commits into from
Mar 26, 2024

Conversation

james7132
Copy link
Member

Objective

CI is currently broken because of DiagnosticsRecorder not being Send and Sync as required by Resource.

Solution

Wrap DiagnosticsRecorder internally with a WgpuWrapper.

@james7132 james7132 added A-Rendering Drawing game state to the screen P-Critical This must be fixed immediately or contributors or users will be severely impacted P-Compile-Failure A failure to compile Bevy apps labels Mar 26, 2024
@bugsweeper bugsweeper mentioned this pull request Mar 26, 2024
Merged
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Mar 26, 2024
jdm
jdm approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 26, 2024
Merged via the queue into bevyengine:main with commit a0f492b Mar 26, 2024
28 checks passed
@bugsweeper bugsweeper mentioned this pull request Mar 26, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen P-Compile-Failure A failure to compile Bevy apps P-Critical This must be fixed immediately or contributors or users will be severely impacted S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@james7132 @jdm @alice-i-cecile