-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math primitives cleanup #13020
Math primitives cleanup #13020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left a couple of nits
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Co-Authored-By: Joona Aalto <jondolf.dev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to hold off on this, as I'm not sure if the machine epsilon is appropriate. The original PR specifically moved away from this approach.
Otherwise looks great!
Co-Authored-By: Miles Silberling-Cook <nth.tensor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to fix the docs so to have the correct epsilon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm & Lgtm! Sorry to make you jump through hoops a bit.
# Objective Adopted #12659. Resolved the merge conflicts on #12659; * I merged the `triangle_tests` added by this PR and by #13020. * I moved the [commented out code](#12659 (comment)) from the original PR into a separate test with `#[should_panic]`. --------- Co-authored-by: Vitor Falcao <vitorfhc@protonmail.com> Co-authored-by: Ben Harper <ben@tukom.org>
Objective
bevy_math
eccentricity()
toEllipse
Solution
Bounded3d
implementation forTriangle3d
to thebounded
moduleeccentricity()
toEllipse
Ellipse::semi_major()
and::semi_minor()
now accept&self
instead ofself
Triangle3d::is_degenerate()
actually usesf32::EPSILON
as documentedTriangle3d
-maths