Extrusion bounded #13346
Merged
Extrusion bounded #13346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthTensor
added
C-Feature
IQuick143
reviewed
May 28, 2024
Co-Authored-By: IQuick 143 <IQuick143cz@gmail.com>
pablo-lua
added
the
S-Needs-Review
alice-i-cecile
requested review from
mweatherley
and removed request for
IQuick143
NthTensor
reviewed
Jun 4, 2024
Comment on lines
+57
to
+59
| let y = signum.y * b * b / (b * b + m * m * a * a).sqrt(); | ||
| let x = signum.x * a * (1. - y * y / b / b).sqrt(); | ||
| rotation * Vec3::new(x, y, 0.) |
There was a problem hiding this comment.
Possible division by zero if ellipse is degenerate?
NthTensor
approved these changes
Jun 4, 2024
alice-i-cecile
approved these changes
Jun 4, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
mweatherley
approved these changes
Jun 4, 2024
| } | ||
| } | ||
|
|
||
| fn bounding_sphere<T: Primitive2d + Bounded2d>( |
There was a problem hiding this comment.
I think this should probably be renamed to something more descriptive which doesn't share a name with the Bounded3d method. Maybe bounding_sphere_from_base or similar?
| fn aabb_3d(&self, translation: Vec3, rotation: Quat) -> Aabb3d { | ||
| let Vec2 { x: a, y: b } = self.base_shape.half_size; | ||
| let normal = rotation * Vec3::Z; | ||
| let conjugate_rot = rotation.conjugate(); |
There was a problem hiding this comment.
I think this is a little more readable:
Suggested change
| let conjugate_rot = rotation.conjugate(); | |
| let inverse_rot = rotation.conjugate(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Bounded3dfor someExtrusion<T>Aabb3ds andBoundingSpheres for any extrusion with aBounded2dbase shapeSolution
Bounded3dfor all 2Dbevy_mathprimitives with the exception ofPlane2d. As far as I can see,Plane2dis pretty much a line? and I think it is very unintuitive to extrude a plane and get a plane as a result.extrusion_bounding_boxandextrusion_bounding_sphere. These are not always used internally since there are faster methods for specific extrusions. Both of them produce the optimal result within precision limits though.Testing