New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse input accumulation #14044

Merged

alice-i-cecile merged 9 commits into bevyengine:main from Aztro-dev:accumulate_mouse_input

Jul 1, 2024

Contributor

Aztro-dev commented Jun 27, 2024 •

edited

Loading

Objective

Add the AccumulatedMouseMotion and AccumulatedMouseScroll resources to make it simpler to track mouse motion/scroll changes
Closes Add resources for accumulated mouse motion and mouse scroll #13915

Solution

Created two resources, AccumulatedMouseMotion and AccumulatedMouseScroll, and a method that tracks the MouseMotion and MouseWheel events and accumulates their deltas every frame.
Also modified the mouse input example to show how to use the resources.

Testing

Tested the changes by modifying an existing example to use the newly added resources, and moving/scrolling my trackpad around a ton.


          Mouse input accumulation

bd5ecc6

alice-i-cecile added A-Input D-Modest S-Needs-Review C-Feature M-Needs-Release-Note labels

alice-i-cecile reviewed

View reviewed changes

examples/input/mouse_input.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

examples/input/mouse_input.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Show resolved Hide resolved

alice-i-cecile reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile requested changes

View reviewed changes

Member

alice-i-cecile left a comment •

edited

Loading

Thanks for tackling this :) I've left some feedback covering how I think we can improve this. If you're looking for ideas on docs or implementation, please feel free to borrow liberally from my implementation in LWIM.

alice-i-cecile added this to the 0.15 milestone

Aztro-dev and others added 4 commits

June 27, 2024 11:21


          Better AccumulateMouseMotion docs

12e522b

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>


          Better AccumulateMouseScroll docs

37c1c26

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>


          Making changes based off of the code reviews

7c21e10


          Added a bit of documentation showing what could happen if you change …

82606a5

…the scroll units

alice-i-cecile approved these changes

View reviewed changes

Member

alice-i-cecile left a comment

Great stuff, thanks for the prompt and agreeable response :)

MScottMcBee reviewed

View reviewed changes

Contributor

MScottMcBee left a comment

It would be great if the mouse_input or mouse_input_events examples were updated to show these off

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved


          Fix docs

ffd3124

Contributor Author

Aztro-dev commented Jun 27, 2024

It would be great if the mouse_input or mouse_input_events examples were updated to show these off

I already updated the mouse_input example, but I don't know if this change would really fit in the mouse_input_events example as we only really implemented a Resource, not an Event

Contributor

MScottMcBee commented Jun 27, 2024 •

edited

Loading

It would be great if the mouse_input or mouse_input_events examples were updated to show these off

I already updated the mouse_input example

Whoops, don't know how I missed that 😅 . LGTM

MScottMcBee approved these changes

View reviewed changes

alice-i-cecile added S-Ready-For-Final-Review and removed S-Needs-Review labels

MrGVSV reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

crates/bevy_input/src/lib.rs Show resolved Hide resolved

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

MrGVSV reviewed

View reviewed changes

crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved

alice-i-cecile added S-Waiting-on-Author and removed S-Ready-For-Final-Review labels

Aztro-dev and others added 3 commits

June 28, 2024 10:37


          Incorporate review suggestions

91e7786


          Update crates/bevy_input/src/mouse.rs

1d4c369

Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>


          Update crates/bevy_input/src/mouse.rs

8b9bb4b

Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>

MrGVSV approved these changes

View reviewed changes

MrGVSV added S-Ready-For-Final-Review and removed S-Waiting-on-Author labels

mweatherley mentioned this pull request

Update examples to use accumulated mouse input #14066

Closed

alice-i-cecile added this pull request to the merge queue

Merged via the queue into bevyengine:main with commit 6dcff2b

28 checks passed

zmbush pushed a commit to zmbush/bevy that referenced this pull request


          Mouse input accumulation (bevyengine#14044)

3abe635

# Objective

- Add the `AccumulatedMouseMotion` and `AccumulatedMouseScroll`
resources to make it simpler to track mouse motion/scroll changes
- Closes bevyengine#13915

## Solution

- Created two resources, `AccumulatedMouseMotion` and
`AccumulatedMouseScroll`, and a method that tracks the `MouseMotion` and
`MouseWheel` events and accumulates their deltas every frame.
- Also modified the mouse input example to show how to use the
resources.

## Testing

- Tested the changes by modifying an existing example to use the newly
added resources, and moving/scrolling my trackpad around a ton.

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>

MrGVSV added a commit to MrGVSV/bevy that referenced this pull request


          Mouse input accumulation (bevyengine#14044)

8aece58

# Objective

- Add the `AccumulatedMouseMotion` and `AccumulatedMouseScroll`
resources to make it simpler to track mouse motion/scroll changes
- Closes bevyengine#13915

## Solution

- Created two resources, `AccumulatedMouseMotion` and
`AccumulatedMouseScroll`, and a method that tracks the `MouseMotion` and
`MouseWheel` events and accumulates their deltas every frame.
- Also modified the mouse input example to show how to use the
resources.

## Testing

- Tested the changes by modifying an existing example to use the newly
added resources, and moving/scrolling my trackpad around a ton.

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>

alice-i-cecile mentioned this pull request

generate-release-notes tool missed some PRs that need stubs bevyengine/bevy-website#1724

Closed

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Input C-Feature D-Modest M-Needs-Release-Note S-Ready-For-Final-Review