[Merged by Bors] - Change breakout to use fixed timestamp #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
mockersf
approved these changes
Mar 3, 2021
|
need a rebase to fix CI |
hymm
force-pushed
the
fix_breakerout_fixed_timestep
branch
from
f442a65
to
eaaef00
Compare
alice-i-cecile
approved these changes
Mar 8, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
cart
reviewed
Mar 10, 2021
hymm
force-pushed
the
fix_breakerout_fixed_timestep
branch
2 times, most recently
from
71fff34
to
aa1542a
Compare
|
Changed the speeds to 8.0 and 6.0 as these were whole numbers close to the original speed and from my eye test it seems like whole numbers animate a little smoother. I should mention that this PR doesn't fix everything from #1240 as there are still some wonky collision detection between the ball and the paddle. |
hymm
force-pushed
the
fix_breakerout_fixed_timestep
branch
from
aa1542a
to
a46f6d6
Compare
cart
reviewed
Mar 14, 2021
examples/game/breakout.rs
Outdated
| @@ -63,7 +72,7 @@ fn setup( | |||
| ..Default::default() | |||
| }) | |||
| .with(Ball { | |||
| velocity: 400.0 * Vec3::new(0.5, -0.5, 0.0).normalize(), | |||
| velocity: 6.0 * Vec3::new(0.5, -0.5, 0.0).normalize(), | |||
There was a problem hiding this comment.
This is still "not velocity" with the new implementation. You effectively pre-multiplied TIME_STEP and velocity. This has the effect of changing object speed if someone changes the timestep value here: https://github.com/bevyengine/bevy/pull/1541/files#diff-4dcbfd17ebad2621b5605be8bd3b43859376e27f30793a937858d470627ed2b2R18
There was a problem hiding this comment.
movement speed should be timestep independent
There was a problem hiding this comment.
Whoops. I shouldn't read comments right before I fall asleep. Should be fixed now.
hymm
force-pushed
the
fix_breakerout_fixed_timestep
branch
from
a46f6d6
to
c02bf1c
Compare
hymm
force-pushed
the
fix_breakerout_fixed_timestep
branch
from
c02bf1c
to
19a1863
Compare
|
Just adapted this to use the newly-added SystemSet. This slightly reduces boilerplate. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2021
This PR fixes #1240, where the ball is escaping the playing field at low framerates. I did this by moving the movement and physics system into a Fixed Timestep system set and changing the movement steps to a constant. So we lose the example use of delta_time for changing position, but gain a use of FixedTimestep. If this is accepted bevyengine/bevy-website#102 will need to be updated to match. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
jihiggins
pushed a commit
to jihiggins/bevy
that referenced
this pull request
Apr 18, 2021
This PR fixes bevyengine#1240, where the ball is escaping the playing field at low framerates. I did this by moving the movement and physics system into a Fixed Timestep system set and changing the movement steps to a constant. So we lose the example use of delta_time for changing position, but gain a use of FixedTimestep. If this is accepted bevyengine/bevy-website#102 will need to be updated to match. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This PR fixes bevyengine#1240, where the ball is escaping the playing field at low framerates. I did this by moving the movement and physics system into a Fixed Timestep system set and changing the movement steps to a constant. So we lose the example use of delta_time for changing position, but gain a use of FixedTimestep. If this is accepted bevyengine/bevy-website#102 will need to be updated to match. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1240, where the ball is escaping the playing field at low framerates. I did this by moving the movement and physics system into a Fixed Timestep system set and changing the movement steps to a constant. So we lose the example use of delta_time for changing position, but gain a use of FixedTimestep.
If this is accepted bevyengine/bevy-website#102 will need to be updated to match.