Support using FilteredResources with ReflectResource. #15624
Merged
+58
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Feature
…rces-ReflectResource
chescock
added
S-Needs-Review
BenjaminBrienen
approved these changes
Oct 13, 2024
BenjaminBrienen
added
the
D-Straightforward
BenjaminBrienen
added
S-Waiting-on-Author
…rces-ReflectResource
chescock
added
S-Needs-Review
| /// Function pointer implementing [`ReflectResource::reflect()`]. | ||
| pub reflect: fn(&World) -> Option<&dyn Reflect>, | ||
| pub reflect: for<'w> fn(FilteredResources<'w, '_>) -> Option<&'w dyn Reflect>, | ||
| /// Function pointer implementing [`ReflectResource::reflect_mut()`]. |
There was a problem hiding this comment.
It would be cool if this could be a static assertion
There was a problem hiding this comment.
I'm not quite sure what you want asserted? I was trying to copy the style of the existing comments, and I think that's meant to be read as "ReflectResource::reflect_mut() invokes this function pointer".
…rces-ReflectResource # Conflicts: # crates/bevy_ecs/src/system/builder.rs
chescock
added
S-Ready-For-Final-Review
alice-i-cecile
added
the
M-Migration-Guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Support accessing resources using reflection when using
FilteredResourcesin a dynamic system. This is similar to how components can be queried using reflection when usingFilteredEntityRef|Mut.Solution
Change
ReflectResourcefrom taking&Worldand&mut Worldto takingimpl Into<FilteredResources>andimpl Into<FilteredResourcesMut>, similar to howReflectComponenttakesimpl Into<FilteredEntityRef>andimpl Into<FilteredEntityMut>. There areFromimpls that ensure code passing&Worldand&mut Worldcontinues to work as before.Migration Guide
If you are manually creating a
ReflectComponentFnsstruct, thereflectfunction now takesFilteredResourcesinstead&World, and there is a newreflect_mutfunction that takesFilteredResourcesMut.