Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extract_text2d_sprite entity leak #15625

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ickshonpe
Copy link
Contributor

Objective

extract_2d_sprite still uses spawn_empty(), replace with spawn(TemporaryRenderEntity) .

@ickshonpe ickshonpe requested a review from UkoeHB October 3, 2024 17:09
@ickshonpe ickshonpe added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen A-Text Rendering and layout for characters labels Oct 3, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 3, 2024
@ickshonpe ickshonpe requested a review from Trashtalk217 October 3, 2024 17:14
Copy link
Contributor

@Trashtalk217 Trashtalk217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ickshonpe ickshonpe changed the title Fix extract_2d_sprite entity leak Fix extract_text2d_sprite entity leak Oct 3, 2024
@ickshonpe ickshonpe added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 3, 2024
Merged via the queue into bevyengine:main with commit 1e61092 Oct 3, 2024
32 checks passed
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Oct 4, 2024
# Objective

`extract_2d_sprite` still uses `spawn_empty()`, replace with
`spawn(TemporaryRenderEntity)` .
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
# Objective

`extract_2d_sprite` still uses `spawn_empty()`, replace with
`spawn(TemporaryRenderEntity)` .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen A-Text Rendering and layout for characters C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants