-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Query::single
and friends to Single
#15872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablo-lua
added
C-Examples
An addition or correction to our examples
C-Code-Quality
A section of code that is hard to understand or change
A-Cross-Cutting
Impacts the entire engine
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
labels
Oct 12, 2024
alice-i-cecile
approved these changes
Oct 13, 2024
I've had to open this up in Codespaces to review it, as Github's webpage hates PRs with many files changed 🙃 That said, looks great! I particularly appreciate the use of |
Guessing this is going to have conflicts after #15857. Can take a look after those get fixed up. |
BenjaminBrienen
approved these changes
Oct 13, 2024
@BenjaminBrienen All comments addressed. |
pablo-lua
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Oct 13, 2024
BenjaminBrienen
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Cross-Cutting
Impacts the entire engine
C-Code-Quality
A section of code that is hard to understand or change
C-Examples
An addition or correction to our examples
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Query::single
withSingle
#15866Solution
Testing
Notes
For now, this PR doesn't migrate
QueryState::single
and friends as for now, this look like another issue. So for example, QueryBuilders that used single orWorld::query
that used single wasn't migrated. If there is a easy way to migrate those, please let me know.Most of the uses of
Query::single
were removed, the only other uses that I found was related to tests of said methods, so will probably be removed when we removeQuery::single
.