Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double MAX_JOINTS and MAX_MORPH_WEIGHTS #15972

Closed
wants to merge 1 commit into from
Closed

Double MAX_JOINTS and MAX_MORPH_WEIGHTS #15972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bevy_mesh/src/morph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const MAX_TEXTURE_WIDTH: u32 = 2048;
const MAX_COMPONENTS: u32 = MAX_TEXTURE_WIDTH * MAX_TEXTURE_WIDTH;

/// Max target count available for [morph targets](MorphWeights).
pub const MAX_MORPH_WEIGHTS: usize = 64;
pub const MAX_MORPH_WEIGHTS: usize = 128;

#[derive(Error, Display, Clone, Debug)]
pub enum MorphBuildError {
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_pbr/src/render/skin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use bevy_render::{
use bevy_transform::prelude::GlobalTransform;

/// Maximum number of joints supported for skinned meshes.
pub const MAX_JOINTS: usize = 256;
pub const MAX_JOINTS: usize = 512;

#[derive(Component)]
pub struct SkinIndex {
Expand Down