Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump accesskit and accesskit_winit. #16234

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Bump accesskit and accesskit_winit. #16234

merged 2 commits into from
Nov 4, 2024

Conversation

ndarilek
Copy link
Contributor

@ndarilek ndarilek commented Nov 4, 2024

Objective

  • Bumps accesskit and accesskit_winit dependencies

Solution

  • Fixes several breaking API changes introduced in accesskit 0.23.

Testing

  • Tested with the ui example and seems to work comparably

@alice-i-cecile alice-i-cecile added C-Dependencies A change to the crates that Bevy depends on A-Accessibility A problem that prevents users with disabilities from using Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 4, 2024
@alice-i-cecile alice-i-cecile added the D-Trivial Nice and easy! A great choice to get started with Bevy label Nov 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 4, 2024
bushrat011899
bushrat011899 suggested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is important to try and land, but the conflict in the name Node is pretty unfortunate in the examples. I've proposed adding a new method to Bevy's AccessibilityNode as a way to avoid needing accesskit::Node in the end-user's namespace.

examples/ui/scroll.rs Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 4, 2024 20:26

Head branch was pushed to by a user without write access

Merged via the queue into bevyengine:main with commit 817f160 Nov 4, 2024
26 checks passed
@bushrat011899 bushrat011899 mentioned this pull request Nov 4, 2024
Closed
@mockersf mockersf modified the milestone: 0.15 Nov 11, 2024
mockersf pushed a commit that referenced this pull request Nov 11, 2024
@ndarilek @mockersf
Bump accesskit and accesskit_winit. (#16234)
8af9b80 
# Objective

- Bumps accesskit and accesskit_winit dependencies

## Solution

- Fixes several breaking API changes introduced in accesskit 0.23.

## Testing

- Tested with the ui example and seems to work comparably
@DataTriny DataTriny mentioned this pull request Nov 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 17, 2024
@DataTriny
Properly set accessible value on label nodes (#16418)
59863d3 
# Objective

AccessKit/accesskit#475 changed how text content
should be set for AccessKit nodes with a role of `Label`. This was
unfortunately missing from #16234.

## Solution

When building an `accesskit::Node` with `Role::Label`, calls `set_value`
instead of `set_label` on the node to set its content.

## Testing

I can't test this right now on my Windows machine due to a compilation
error with wgpu-hal I have no idea how to resolve.
mockersf pushed a commit that referenced this pull request Nov 17, 2024
@DataTriny @mockersf
Properly set accessible value on label nodes (#16418)
a5ec9be 
# Objective

AccessKit/accesskit#475 changed how text content
should be set for AccessKit nodes with a role of `Label`. This was
unfortunately missing from #16234.

## Solution

When building an `accesskit::Node` with `Role::Label`, calls `set_value`
instead of `set_label` on the node to set its content.

## Testing

I can't test this right now on my Windows machine due to a compilation
error with wgpu-hal I have no idea how to resolve.
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
@ndarilek @ecoskey
Bump accesskit and accesskit_winit. (bevyengine#16234)
ffea6c5 
# Objective

- Bumps accesskit and accesskit_winit dependencies

## Solution

- Fixes several breaking API changes introduced in accesskit 0.23.

## Testing

- Tested with the ui example and seems to work comparably
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
@DataTriny @ecoskey
Properly set accessible value on label nodes (bevyengine#16418)
cfb0296 
# Objective

AccessKit/accesskit#475 changed how text content
should be set for AccessKit nodes with a role of `Label`. This was
unfortunately missing from bevyengine#16234.

## Solution

When building an `accesskit::Node` with `Role::Label`, calls `set_value`
instead of `set_label` on the node to set its content.

## Testing

I can't test this right now on my Windows machine due to a compilation
error with wgpu-hal I have no idea how to resolve.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bushrat011899 bushrat011899 bushrat011899 requested changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Accessibility A problem that prevents users with disabilities from using Bevy C-Dependencies A change to the crates that Bevy depends on D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@ndarilek @bushrat011899 @alice-i-cecile @mockersf