Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UiImage -> ImageNode, UiImageSize -> ImageNodeSize #16271

Merged
merged 1 commit into from
Nov 7, 2024
Merged

UiImage -> ImageNode, UiImageSize -> ImageNodeSize #16271

merged 1 commit into from
Nov 7, 2024

Conversation

cart
Copy link
Member

@cart cart commented Nov 6, 2024

Objective

Align UiImage with the new XNode naming convention.

Solution

  • Rename UiImage to ImageNode
  • Rename UiImageSize to ImageNodeSize

Migration Guide

Before:

commands.spawn(UiImage::new(image));

After:

commands.spawn(ImageNode::new(image));

@cart cart added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 6, 2024
@cart cart added this to the 0.15 milestone Nov 6, 2024
@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Nov 6, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 6, 2024
@cart cart added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@cart cart added this pull request to the merge queue Nov 7, 2024
@cart
Copy link
Member Author

cart commented Nov 7, 2024

(merge failed due to a 500 server error when running the wasm examples so i requeued)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@cart cart enabled auto-merge November 7, 2024 21:33
@cart cart changed the base branch from main to release-0.15.0 November 7, 2024 21:34
@cart cart changed the base branch from release-0.15.0 to main November 7, 2024 21:35
@cart
Copy link
Member Author

cart commented Nov 7, 2024

Weird. It says there are conflicts on main but I'm not seeing any locally. Tried a change of base to force github to reconsider, but it is resolute.

@cart
Copy link
Member Author

cart commented Nov 7, 2024

Ahhhh this PR is from origin/image-node instead of cart/image-node so none of my changes were getting picked up. Bad cart!

@cart cart added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit f754cec Nov 7, 2024
29 checks passed
mockersf pushed a commit that referenced this pull request Nov 11, 2024
@cart @mockersf
UiImage -> ImageNode, UiImageSize -> ImageNodeSize (#16271)
197e5a4 
Align `UiImage` with the new `XNode` naming convention.

- Rename `UiImage` to `ImageNode`
- Rename `UiImageSize` to `ImageNodeSize`

---

Before:
```rust
commands.spawn(UiImage::new(image));
````

After:
```rust
commands.spawn(ImageNode::new(image));
```
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
@cart @ecoskey
UiImage -> ImageNode, UiImageSize -> ImageNodeSize (bevyengine#16271)
b4286b4 
# Objective

Align `UiImage` with the new `XNode` naming convention.

## Solution

- Rename `UiImage` to `ImageNode`
- Rename `UiImageSize` to `ImageNodeSize`

---

## Migration Guide

Before:
```rust
commands.spawn(UiImage::new(image));
````

After:
```rust
commands.spawn(ImageNode::new(image));
```
@mgi388 mgi388 mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@doup doup doup approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
3 participants
@cart @doup @alice-i-cecile