Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the coordinate rounding from extract_text_sections. The coor… #16616

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Remove the coordinate rounding from extract_text_sections. The coor… #16616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06db72f
Remove the coordinate rounding from `extract_text_sections`. The coor…
ickshonpe Dec 2, 2024
a6ccca6
Merge branch 'main' into remove-rounding-in-extract-text-sections
ickshonpe Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions crates/bevy_ui/src/render/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,14 +654,8 @@ pub fn extract_text_sections(
continue;
};

// Align the text to the nearest pixel:
// * Translate by minus the text node's half-size
// (The transform translates to the center of the node but the text coordinates are relative to the node's top left corner)
// * Round the position to the nearest physical pixel

let mut transform = global_transform.affine()
let transform = global_transform.affine()
* bevy_math::Affine3A::from_translation((-0.5 * uinode.size()).extend(0.));
transform.translation = transform.translation.round();

let mut color = LinearRgba::WHITE;
let mut current_span = usize::MAX;
Expand Down
Loading