BorderRect maintenance
#16727
Merged
BorderRect maintenance
#16727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed `square` to `all`. * Renamed `rectangle` to `axes`. * Renamed `value` to `extent`. * Updated the doc comments.
ickshonpe
added
A-UI
rparrett
reviewed
Dec 9, 2024
| #[derive(Default, Copy, Clone, PartialEq, Debug, Reflect)] | ||
| pub struct BorderRect { | ||
| /// Pixel padding to the left |
There was a problem hiding this comment.
As far as I know, this was the only hint in docs in anything related to texture slicing about the values being in pixels. So it would be great to get that information back somewhere.
There was a problem hiding this comment.
Yep I'll add something to the TextureSlicer docs I think. BorderRect is used in different coordinate spaces so it doesn't make sense to refer to pixels here.
alice-i-cecile
added
the
M-Needs-Migration-Guide
|
I like these changes, but seconding the request not to lose the information about pixels :) |
alice-i-cecile
approved these changes
Dec 11, 2024
BenjaminBrienen
approved these changes
Dec 11, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
CI failure seems real and related: I think there's a conditional compilation issue here. |
|
I think it's just new stuff from #16693 that needs to be updated. |
BenjaminBrienen
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The doc comments and function namings for
BorderRectfeel imprecise to me. Particularly thesquarefunction which is used to define a uniformBorderRectwith equal widths on each edge. But this is potentially confusing since this "square" border could be around an oblong shape.Using "padding" to refer to the border extents seems undesirable too since "padding" is typically used to refer to the area between border and content, not the border itself.
Solution
squaretoall(this matches the name of the similar method onUiRect).rectangletoaxes(this matches the name of the similar method onUiRect).Migration Guide
The
squareandrectanglefunctions belonging toBorderRecthave been renamed toallandaxes.