Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I was curious to use the newly created
bevy_input_focus
, but I found some issues with itWorld
.is_focus_within
logic was incorrect.Solution
This PR includes some improvements to the
bevy_input_focus
crate:IsFocusedHelper
that doesn't require access to&World
. It implementsIsFocused
IsFocused
impl forDeferredWorld
. Since it already implementsDeref<Target=World>
it was just duplication of code.SetInputFocus
forCommands
. There was no way to useSetFocusCommand
directly. This allows it.is_focus_within
logic has been fixed to check descendants. Previously it was checking if any of the ancestors had focus which is not correct according to the documentation.Testing