Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bevy_core #16897

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Remove bevy_core #16897

merged 6 commits into from
Dec 19, 2024

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Removed TypeRegistryPlugin (Name is now automatically registered with a default App)
  • Moved TaskPoolPlugin to bevy_app
  • Moved FrameCountPlugin to bevy_diagnostic
  • Deleted now-empty bevy_core

Testing

  • CI

Migration Guide

  • TypeRegistryPlugin no longer exists. If you can't use a default App but still need Name registered, do so manually with app.register_type::<Name>().
  • References to TaskPoolPlugin and associated types will need to import it from bevy_app instead of bevy_core
  • References to FrameCountPlugin and associated types will need to import it from bevy_diagnostic instead of bevy_core

Notes

This strategy was agreed upon by Cart and several other members in Discord.

@bushrat011899 bushrat011899 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Core X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 19, 2024
@bushrat011899
Copy link
Contributor Author

I've marked this as X-Blessed based on Cart's approval of my proposal, but please remove it if that's inappropriate!

Copy link
Member

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth noting the path change to Name for people migrating their scene files.

@ItsDoot
Copy link
Contributor

ItsDoot commented Dec 19, 2024

Probably worth noting the path change to Name for people migrating their scene files.

That should be covered by the migration guide in #16894

@bushrat011899
Copy link
Contributor Author

Probably worth noting the path change to Name for people migrating their scene files.

Yeah as @ItsDoot mentioned it's covered by #16894's migration guide. I just missed this instance and it slipped through CI, so I fixed it here since it's somewhat related.

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 19, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 19, 2024
Merged via the queue into bevyengine:main with commit 2178663 Dec 19, 2024
33 checks passed
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
# Objective

- Fixes bevyengine#16892

## Solution

- Removed `TypeRegistryPlugin` (`Name` is now automatically registered
with a default `App`)
- Moved `TaskPoolPlugin` to `bevy_app`
- Moved `FrameCountPlugin` to `bevy_diagnostic`
- Deleted now-empty `bevy_core`

## Testing

- CI

## Migration Guide

- `TypeRegistryPlugin` no longer exists. If you can't use a default
`App` but still need `Name` registered, do so manually with
`app.register_type::<Name>()`.
- References to `TaskPoolPlugin` and associated types will need to
import it from `bevy_app` instead of `bevy_core`
- References to `FrameCountPlugin` and associated types will need to
import it from `bevy_diagnostic` instead of `bevy_core`

## Notes

This strategy was agreed upon by Cart and several other members in
[Discord](https://discord.com/channels/691052431525675048/692572690833473578/1319137218312278077).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up bevy_core
4 participants