-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bevy_core
#16897
Remove bevy_core
#16897
Conversation
`Name` will be explicitly registered in a `Default` `App`
I've marked this as |
cafb38d
to
804ac03
Compare
…into DestroyTheCore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth noting the path change to Name
for people migrating their scene files.
That should be covered by the migration guide in #16894 |
# Objective - Fixes bevyengine#16892 ## Solution - Removed `TypeRegistryPlugin` (`Name` is now automatically registered with a default `App`) - Moved `TaskPoolPlugin` to `bevy_app` - Moved `FrameCountPlugin` to `bevy_diagnostic` - Deleted now-empty `bevy_core` ## Testing - CI ## Migration Guide - `TypeRegistryPlugin` no longer exists. If you can't use a default `App` but still need `Name` registered, do so manually with `app.register_type::<Name>()`. - References to `TaskPoolPlugin` and associated types will need to import it from `bevy_app` instead of `bevy_core` - References to `FrameCountPlugin` and associated types will need to import it from `bevy_diagnostic` instead of `bevy_core` ## Notes This strategy was agreed upon by Cart and several other members in [Discord](https://discord.com/channels/691052431525675048/692572690833473578/1319137218312278077).
Objective
bevy_core
#16892Solution
TypeRegistryPlugin
(Name
is now automatically registered with a defaultApp
)TaskPoolPlugin
tobevy_app
FrameCountPlugin
tobevy_diagnostic
bevy_core
Testing
Migration Guide
TypeRegistryPlugin
no longer exists. If you can't use a defaultApp
but still needName
registered, do so manually withapp.register_type::<Name>()
.TaskPoolPlugin
and associated types will need to import it frombevy_app
instead ofbevy_core
FrameCountPlugin
and associated types will need to import it frombevy_diagnostic
instead ofbevy_core
Notes
This strategy was agreed upon by Cart and several other members in Discord.