Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NodeImageMode to ImageNodeMode #17013

Closed
wants to merge 1 commit into from
Closed

Rename NodeImageMode to ImageNodeMode #17013

wants to merge 1 commit into from

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Fixes #16909

Solution

Rename the type

Migration Guide

widget::image::NodeImageMode is now widget::image::ImageNodeMode

@BenjaminBrienen BenjaminBrienen self-assigned this Dec 28, 2024
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 28, 2024
ickshonpe
ickshonpe reviewed Dec 28, 2024
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer NodeImageMode.

@BenjaminBrienen BenjaminBrienen deleted the 16909 branch December 28, 2024 23:27
@BenjaminBrienen BenjaminBrienen added S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ickshonpe ickshonpe ickshonpe left review comments

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming NodeImageMode to ImageNodeMode
2 participants
@BenjaminBrienen @ickshonpe