Skip to content

Conversation

@mdickopp
Copy link
Contributor

Objective

Fixes #17004

Solution

Store BevyManifest instances in a hash map keyed on the value of the CARGO_MANIFEST_DIR environment variable. This causes one BevyManifest instance per crate to be created.

Testing

@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior A-Cross-Cutting Impacts the entire engine D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 12, 2025
@mdickopp mdickopp marked this pull request as ready for review January 12, 2025 12:09
@mdickopp
Copy link
Contributor Author

Closing in favor of #17330.

@mdickopp mdickopp closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Cross-Cutting Impacts the entire engine C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rust-analyzer autocomplete is broken for some ECS types

2 participants