Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Disable frustum culling and add warning #1761

Closed
wants to merge 1 commit into from

Conversation

cart
Copy link
Member

@cart cart commented Mar 25, 2021

Frustum culling has some pretty major gaps right now (such as not supporting sprite transform scaling and not taking into account projections). It should be disabled by default until it provides a solid experience across all bevy use cases.

@cart cart added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Mar 25, 2021
@cart cart added this to the Bevy 0.5 milestone Mar 25, 2021
@DJMcNab DJMcNab added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 25, 2021
@cart cart mentioned this pull request Mar 25, 2021
@cart
Copy link
Member Author

cart commented Mar 25, 2021

bors r+

bors bot pushed a commit that referenced this pull request Mar 25, 2021
Frustum culling has some pretty major gaps right now (such as not supporting sprite transform scaling and not taking into account projections). It should be disabled by default until it provides a solid experience across all bevy use cases.
@bors bors bot changed the title Disable frustum culling and add warning [Merged by Bors] - Disable frustum culling and add warning Mar 25, 2021
@bors bors bot closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants