Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused #[must_used] #17959

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Remove unused #[must_used] #17959

merged 1 commit into from
Feb 21, 2025

Conversation

bushrat011899
Copy link
Contributor

Objective

  • Fixed CI compilation failure on Rust Nightly 1.87 due to this PR

Solution

  • Removed unused #[must_use]

Testing

  • cargo +nightly check --target wasm32-unknown-unknown -Z build-std=std,panic_abort

@bushrat011899 bushrat011899 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-App Bevy apps and plugins P-Compile-Failure A failure to compile Bevy apps X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 21, 2025
This was referenced Feb 21, 2025
Merged
Open
@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 21, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 21, 2025
Merged via the queue into bevyengine:main with commit 6bcb2b6 Feb 21, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsDoot ItsDoot ItsDoot approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bushrat011899 @ItsDoot @alice-i-cecile