NamedHierachy for find entities #1830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
mockersf
reviewed
Apr 6, 2021
| /// this function takes an vec of entities defined by their parent index | ||
| /// (on the same vec) and name. | ||
| /// | ||
| /// Any root entity should be indexed using `I::MAX_VALUE` or `I::MAX`. |
There was a problem hiding this comment.
could you add a const on NamedHierarchy to help this?
const ROOT_ENTITY: I = I::MAX_VALUE;and then document to use NamedHierarchy::ROOT_ENTITY instead of I::MAX_VALUE
There was a problem hiding this comment.
I liked this suggestion, but I used the NO_PARENT, the wording of this docs wasn't right. It's not the index of the root entity but the index of the root parent entity
lassade
added a commit
to lassade/bevy
that referenced
this pull request
Apr 11, 2021
5 tasks
cart
added
the
S-Pre-Relicense
mockersf
removed
the
S-Pre-Relicense
alice-i-cecile
added
the
S-Needs-Design-Doc
alice-i-cecile
added
the
X-Controversial
|
This has unfortunately drifted a bit too far from our current animation implementation, and I have concerns about it's global nature. There may be use in the future for such a cached hierarchy for name queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by #1429, used to find witch entities to animate given a set of named entities;