Fix unecessary specialization checks for apps with many materials #18410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibly need specialization.
tychedelia
added
C-Bug
tychedelia
added
the
S-Needs-Review
JMS55
approved these changes
Mar 19, 2025
Contributor
JMS55
left a comment
JMS55
left a comment
There was a problem hiding this comment.
Lgtm.
We never did cold specialization for meshlet meshes, right?
Member
Author
Yup, I promised to do so and then it slipped my mind. My 0.16 list is a little long right now but totally still happy to do it if there's time to get it in or right after. |
Contributor
|
No worries. Lets do it for 0.17. |
superdump
approved these changes
Mar 19, 2025
mockersf
pushed a commit
that referenced
this pull request
Mar 19, 2025
…8410) # Objective For materials that aren't being used or a visible entity doesn't have an instance of, we were unnecessarily constantly checking whether they needed specialization, saying yes (because the material had never been specialized for that entity), and failing to look up the material instance. ## Solution If an entity doesn't have an instance of the material, it can't possibly need specialization, so exit early before spending time doing the check. Fixes #18388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
For materials that aren't being used or a visible entity doesn't have an instance of, we were unnecessarily constantly checking whether they needed specialization, saying yes (because the material had never been specialized for that entity), and failing to look up the material instance.
Solution
If an entity doesn't have an instance of the material, it can't possibly need specialization, so exit early before spending time doing the check.
Fixes #18388.