-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand MergeMeshError to include IncompatiblePrimitiveTopology variant #18561
base: main
Are you sure you want to change the base?
Expand MergeMeshError to include IncompatiblePrimitiveTopology variant #18561
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
@alice-i-cecile I added a migration guide file, does it look fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use a shorter snake case name for the migration guide file? Like merge_mesh_errors.md
? @alice-i-cecile do you have preferences about the format?
Agreed; short snake_case name that mentions the type that was changed please. |
Objective
Fix #18546 by adding a variant to
MergeMeshError
, for incompatible primitive topologies.Solution
Made
MergeMeshError
into an enum with two variants;IncompatibleVertexAttributes
andIncompatiblePrimitiveTopology
.Added an if statement in
Mesh::merge
to check if theprimitive_topology
field ofself
matchesother
.Also renamed
MergeMeshError
toMeshMergeError
to align with the two otherMeshSomethingError
's.Testing
Didn't do any.