[Merged by Bors] - Make some asset loading functions monomorphic #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Apr 9, 2021
alice-i-cecile
added
A-Assets
|
For cg_llvm in release mode breakout shrinks from 356k to 316k. For cg_llvm in debug mode breakout shrinks from 3814k to 3057k. |
bjorn3
force-pushed
the
monomorphize_asset_loading
branch
3 times, most recently
from
a6217c2
to
0851fd8
Compare
cart
reviewed
Apr 9, 2021
| } | ||
|
|
||
| // TODO: properly set failed LoadState in all failure cases | ||
| async fn load_async<'a, P: Into<AssetPath<'a>>>( | ||
| async fn load_async<'a>( |
There was a problem hiding this comment.
For now I think this is reasonable because we don't export it. But some potential future pub async load_async() variant should be generic to have parity with load().
This reduces the size of executables when using bevy as dylib by ensuring that they get codegened in bevy_assets instead of the game itself. This by extension avoids pulling in parts of bevy_tasks and async_task. Before this change the breakout example was 923k big after this change it is only 775k big for cg_clif. For cg_llvm in release mode breakout shrinks from 356k to 316k. For cg_llvm in debug mode breakout shrinks from 3814k to 3057k.
bjorn3
force-pushed
the
monomorphize_asset_loading
branch
from
0851fd8
to
8592b86
Compare
|
CI passes. |
bjorn3
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2021
This reduces the size of executables when using bevy as dylib by ensuring that they get codegened in bevy_assets instead of the game itself. This by extension avoids pulling in parts of bevy_tasks and async_task. Before this change the breakout example was 923k big after this change it is only 775k big for cg_clif. For cg_llvm in release mode breakout shrinks from 356k to 316k. For cg_llvm in debug mode breakout shrinks from 3814k to 3057k.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
3 tasks
jihiggins
pushed a commit
to jihiggins/bevy
that referenced
this pull request
Apr 18, 2021
This reduces the size of executables when using bevy as dylib by ensuring that they get codegened in bevy_assets instead of the game itself. This by extension avoids pulling in parts of bevy_tasks and async_task. Before this change the breakout example was 923k big after this change it is only 775k big for cg_clif. For cg_llvm in release mode breakout shrinks from 356k to 316k. For cg_llvm in debug mode breakout shrinks from 3814k to 3057k.
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This reduces the size of executables when using bevy as dylib by ensuring that they get codegened in bevy_assets instead of the game itself. This by extension avoids pulling in parts of bevy_tasks and async_task. Before this change the breakout example was 923k big after this change it is only 775k big for cg_clif. For cg_llvm in release mode breakout shrinks from 356k to 316k. For cg_llvm in debug mode breakout shrinks from 3814k to 3057k.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of executables when using bevy as dylib by
ensuring that they get codegened in bevy_assets instead of the game
itself. This by extension avoids pulling in parts of bevy_tasks and
async_task.
Before this change the breakout example was 923k big after this change
it is only 775k big for cg_clif. For cg_llvm in release mode breakout
shrinks from 356k to 316k. For cg_llvm in debug mode breakout shrinks
from 3814k to 3057k.