Fix wrong method call in relationship replacement command #18824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaySpruce
added
C-Bug
cart
approved these changes
Apr 14, 2025
mockersf
pushed a commit
that referenced
this pull request
Apr 14, 2025
Fixes a small mix-up from #18058, which added bulk relationship replacement methods. `EntityCommands::replace_related_with_difference` calls `EntityWorldMut::replace_children_with_difference` instead of `EntityWorldMut::replace_related_with_difference`, which means it always operates on the `ChildOf` relationship instead of the `R: Relationship` generic it's provided. `EntityCommands::replace_children_with_difference` takes an `R: Relationship` generic that it shouldn't, but it accidentally works correctly on `main` because it calls the above method.
jf908
pushed a commit
to jf908/bevy
that referenced
this pull request
May 12, 2025
…#18824) Fixes a small mix-up from bevyengine#18058, which added bulk relationship replacement methods. `EntityCommands::replace_related_with_difference` calls `EntityWorldMut::replace_children_with_difference` instead of `EntityWorldMut::replace_related_with_difference`, which means it always operates on the `ChildOf` relationship instead of the `R: Relationship` generic it's provided. `EntityCommands::replace_children_with_difference` takes an `R: Relationship` generic that it shouldn't, but it accidentally works correctly on `main` because it calls the above method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small mix-up from #18058, which added bulk relationship replacement methods.
EntityCommands::replace_related_with_differencecallsEntityWorldMut::replace_children_with_differenceinstead ofEntityWorldMut::replace_related_with_difference, which means it always operates on theChildOfrelationship instead of theR: Relationshipgeneric it's provided.EntityCommands::replace_children_with_differencetakes anR: Relationshipgeneric that it shouldn't, but it accidentally works correctly onmainbecause it calls the above method.