Skip to content

Conversation

JaySpruce
Copy link
Member

Fixes #18834.

EntityWorldMut::remove_children and EntityCommands::remove_children were removed in the relationships overhaul (#17398) and never got replaced.

I don't think this was intentional (the methods were never mentioned in the PR or its comments), but I could've missed something.

@JaySpruce JaySpruce added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 13, 2025
@JaySpruce JaySpruce added this to the 0.16 milestone Apr 13, 2025
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@cart cart added this pull request to the merge queue Apr 14, 2025
Merged via the queue into bevyengine:main with commit 045ef4c Apr 14, 2025
39 checks passed
@JaySpruce JaySpruce deleted the remove_children branch April 14, 2025 21:02
mockersf pushed a commit that referenced this pull request Apr 14, 2025
…ntityCommands` (#18835)

Fixes #18834.

`EntityWorldMut::remove_children` and `EntityCommands::remove_children`
were removed in the relationships overhaul (#17398) and never got
replaced.

I don't *think* this was intentional (the methods were never mentioned
in the PR or its comments), but I could've missed something.
jf908 pushed a commit to jf908/bevy that referenced this pull request May 12, 2025
…ntityCommands` (bevyengine#18835)

Fixes bevyengine#18834.

`EntityWorldMut::remove_children` and `EntityCommands::remove_children`
were removed in the relationships overhaul (bevyengine#17398) and never got
replaced.

I don't *think* this was intentional (the methods were never mentioned
in the PR or its comments), but I could've missed something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing 0.16 migration path for EntityWorldMut::remove_children, which could remove only particular children
3 participants