-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add test that repros #11111 (different loader settings produce same asset) #19094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 6 commits into
bevyengine:main
from
greeble-dev:repro-asset-with-different-settings-2
Jul 2, 2025
Merged
Add test that repros #11111 (different loader settings produce same asset) #19094
alice-i-cecile
merged 6 commits into
bevyengine:main
from
greeble-dev:repro-asset-with-different-settings-2
Jul 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a `#[should_panic]`.
Member
|
I think this behavior is a bug: doing distinct things with the same asset is a relatively common pattern. |
alice-i-cecile
approved these changes
May 7, 2025
andriyDev
approved these changes
Jul 2, 2025
Merged
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
…in AssetServer::load() (#20562) # Objective - Fixes #19844 ## Solution - Revert #10823 - Also reverts #19094, as the ignored test added there does not compile with the new lifetime rules. ## TODO This PR was made > 10k issues ago, and git can do funky things. Opening as a draft to investigate the diff before proceeding. - [x] merge main into the old branch - [x] revert the PR - [x] make sure the diff looks okay - [x] add comments explaining why we did this weird thing --------- Co-authored-by: Zac Harrold <zac@harrold.com.au>
andriyDev
added a commit
to andriyDev/bevy
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Assets
Load files from disk to use for things like images, models, and sounds
C-Testing
A change that impacts how we test Bevy or how users test their apps
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
X-Contentious
There are nontrivial implications that should be thought through
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add a test that reproduces #11111 (and partially #18267). The bug is that asset loader settings are effectively ignored if the same asset is loaded multiple times with different settings.
Solution
Add a unit test to
bevy_assets/lib.rs. The test will be marked as#[ignore]until #11111 is fixed.Concerns
I'm not 100% sure that the current behaviour is actually broken - I can't see anything in the asset system design docs that explicitly says different settings should create different asset ids.
UPDATE: Sentiment from issue comments and discord varies between "bug" and "undesirable consequence of design decisions, alternatives should be explored". So I've concluded that the test is valid and desirable.
Testing