Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add render_to_texture example #1927

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - add render_to_texture example #1927

wants to merge 9 commits into from

Conversation

mrk-its
Copy link
Member

@mrk-its mrk-its commented Apr 14, 2021

No description provided.

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Rendering Drawing game state to the screen labels Apr 14, 2021
MinerSebas
MinerSebas reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@MinerSebas MinerSebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the example to the README.md in the examples folder.

examples/3d/render_to_texture.rs Outdated Show resolved Hide resolved
@alice-i-cecile
Copy link
Member

This is half-way to #22, correct?

@mrk-its @MinerSebas
address reviewer comment
26bf253 
Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
@mockersf mockersf mentioned this pull request Apr 17, 2021
Closed
@mrk-its
Copy link
Member Author

mrk-its commented Apr 17, 2021

This is half-way to #22, correct?

Yes. The TextureNode from this PR may be used as replacement of WindowSwapChainNode, I've created POC: https://github.com/mrk-its/bevy/blob/render_to_file/examples/3d/render_to_file.rs.

@mrk-its
Copy link
Member Author

mrk-its commented Apr 18, 2021

Please also add the example to the README.md in the examples folder.

done

@mrk-its mrk-its marked this pull request as ready for review April 18, 2021 10:05
@mtsr
Copy link
Contributor

mtsr commented Apr 18, 2021

Thank you for this, @mrk-its!

I'm already thinking how we can add a post-process pass, once this is merged. I already have an upscale + post-process pass in my own prototype, but it's probably a bit of work to make it generic enough to PR.

@cart
Copy link
Member

cart commented Apr 19, 2021

Looks good to me! Just made some small tweaks to the trait / components in the example to cut down on boilerplate and be a bit more explicit. (As an aside, I'd like to consider moving away from the "graph extension trait" pattern internally as well. I think functions work fine, but we could also consider a single "graph plugin" trait as an alternative)

@cart
Copy link
Member

cart commented Apr 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 19, 2021
@mrk-its @cart
add render_to_texture example (#1927)
fa6d4db 
Co-authored-by: Carter Anderson <mcanders1@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 19, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add render_to_texture example [Merged by Bors] - add render_to_texture example Apr 19, 2021
@bors bors bot closed this Apr 19, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@mrk-its @cart @ostwilkens
add render_to_texture example (bevyengine#1927)
ad6897d 
Co-authored-by: Carter Anderson <mcanders1@gmail.com>
@alice-i-cecile alice-i-cecile mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerSebas MinerSebas MinerSebas left review comments

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrk-its @alice-i-cecile @mtsr @cart @MinerSebas