Skip to content

force unclipped depth emu on webgpu #19785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

force unclipped depth emu on webgpu #19785

wants to merge 2 commits into from

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Jun 23, 2025

Objective

fixes #19626

Solution

it seems like on webgpu the render device may report DEPTH_CLIP_CONTROL without actually supporting it, so we force emulated mode for webgpu.

Jondolf
Jondolf reviewed Jun 23, 2025
View reviewed changes
@robtfm @Jondolf
Update crates/bevy_pbr/src/prepass/mod.rs
b7525b6 
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen O-WebGPU Specific to the WebGPU render API D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 23, 2025
alice-i-cecile
alice-i-cecile reviewed Jun 23, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to open a bug upstream and link it here (and in the code) before merging this. Fixes seems very sensible though.

@atlv24 atlv24 mentioned this pull request Jun 23, 2025
Merged
6 tasks
@atlv24
Copy link
Contributor

atlv24 commented Jun 23, 2025

Superseded by gfx-rs/wgpu#7841

And I'll try to get us a backport patch release

@janhohenheim janhohenheim mentioned this pull request Jun 29, 2025
Open
@janhohenheim janhohenheim added the S-Nominated-To-Close A triage team member thinks this PR or issue should be closed out. label Jun 29, 2025
@atlv24 atlv24 mentioned this pull request Jul 31, 2025
Merged
@atlv24 atlv24 closed this Aug 2, 2025
@github-project-automation github-project-automation bot moved this to Done in Rendering Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

+1 more reviewer

@Jondolf Jondolf Jondolf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-WebGPU Specific to the WebGPU render API S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Nominated-To-Close A triage team member thinks this PR or issue should be closed out.

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Directional lights ignore walls on WebGPU when the camera is too parallel to them

5 participants

@robtfm @atlv24 @alice-i-cecile @Jondolf @janhohenheim