Skip to content

Conversation

@ecoskey
Copy link
Contributor

@ecoskey ecoskey commented Jul 1, 2025

Objective

Testing

  • bloom_3d example works

For reviewers:

Please bikeshed! This is where we start to make patterns for using spec_v2. Some initial thoughts:

  • all the .as_mut().unwrap() obviously won't work. We need accessors of some kind, what should that look like?
  • Similarly, base descriptors can't always fill in every field. Should we add a set of placeholder values?
    • @atlv24 and @tychedelia have mentioned removing custom base descriptors, and providing a single default descriptor. I'm not convinced it's a good solution yet, but it's worth considering.
  • Getting resources from the specializer outside specialization feels gross. GetBaseDescriptor seems to emphasize this pattern.
    • should we remove GetBaseDescriptor entirely?
    • I think a good pattern might be storing static pipeline resources (shaders, layout) on a plain resource, and using a base_descriptor method on that resource to create the SpecializedCache. That way, specializers would only contain the things they need to perform specialization.

}

impl FromWorld for SpecializeBloomDownsample {
fn from_world(world: &mut World) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need those anymore 👀

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 1, 2025
@ecoskey ecoskey closed this Jul 3, 2025
@github-project-automation github-project-automation bot moved this to Done in Rendering Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants