Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Testing
bloom_3dexample worksFor reviewers:
Please bikeshed! This is where we start to make patterns for using
spec_v2. Some initial thoughts:.as_mut().unwrap()obviously won't work. We need accessors of some kind, what should that look like?GetBaseDescriptorseems to emphasize this pattern.GetBaseDescriptorentirely?base_descriptormethod on that resource to create theSpecializedCache. That way, specializers would only contain the things they need to perform specialization.