Skip to content

spec_v2: minor revisions #19923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 3, 2025
Merged

spec_v2: minor revisions #19923

merged 21 commits into from
Jul 3, 2025

Conversation

@ecoskey
Copy link
Contributor

@ecoskey ecoskey commented Jul 2, 2025 •
edited
Loading

  • renamed spec_v2 related modules, that commit slipped through the other pr Composable Pipeline Specialization #17373
  • revised struct and trait docs for clarity, and gave a short intro to specialization
  • turns out the derive macro was broken, fixed that too

@greeble-dev greeble-dev added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 2, 2025
@alice-i-cecile
Copy link
Member

@ecoskey I would merge this but CI is red :)

@ecoskey
Copy link
Contributor Author

ecoskey commented Jul 2, 2025

oops, will fix after work

@ecoskey
Copy link
Contributor Author

ecoskey commented Jul 3, 2025

finally green!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 3, 2025
Merged via the queue into bevyengine:main with commit bbf91a6 Jul 3, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@IceSentry IceSentry IceSentry approved these changes

@atlv24 atlv24 atlv24 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ecoskey @alice-i-cecile @IceSentry @atlv24 @greeble-dev