-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Deprecate iter_entities
and iter_entities_mut
#20260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 12 commits into
bevyengine:main
from
Trashtalk217:deprecate-iter-entities
Jul 23, 2025
Merged
Deprecate iter_entities
and iter_entities_mut
#20260
alice-i-cecile
merged 12 commits into
bevyengine:main
from
Trashtalk217:deprecate-iter-entities
Jul 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
Jul 23, 2025
Carter0
reviewed
Jul 23, 2025
Carter0
reviewed
Jul 23, 2025
Co-authored-by: Carter Weinberg <weinbergcarter@gmail.com>
Co-authored-by: Carter Weinberg <weinbergcarter@gmail.com>
Carter0
approved these changes
Jul 23, 2025
Waiting on a quick test to ensure the workaround in the migration guide keeps working, then I'll be comfortable merging this. |
alice-i-cecile
approved these changes
Jul 23, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Code-Quality
A section of code that is hard to understand or change
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Both
iter_entities()
anditer_entities_mut
are awkward functions as they both return all entities, which is something you (should) rarely want.Solution
Deprecate both functions and substitute them where they are used.
Testing
Not necessary.