-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add light_consts::lumens::VERY_LARGE_CINEMA_LIGHT #20363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,7 +152,7 @@ fn toggle_light( | |
for mut light in &mut point_lights { | ||
light.intensity = if light.intensity == 0.0 { | ||
*writer.text(*example_text, 4) = "PointLight".to_string(); | ||
100000000.0 | ||
light_consts::lumens::VERY_LARGE_CINEMA_LIGHT | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. VERY_LARGE_CINEMA_LIGHT is 1_000_000 not 100_000_000, does this work well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, its extremely blown-out on main, seems like it was left behind during some unit change. This looks more normal There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems like both the directional light and point light are blown out (it uses directional by default), maybe this is on purpose? With this PR the directional and point look pretty different. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if it was on purpose the scene wouldnt be constructed with a DirectionalLight::default added, it'd have the brightness set to match the cycler. The cycler is just from a time the units were different There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Really the PointLight and DirectionalLight should probably both be default, and one or the other should be Disabled by the cycler, but i dont think that works yet There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One way or another, the PointLight and DirectionalLight match much more closely on main than in this PR. Both with the initial values on main and also the values that are used after switching. |
||
} else { | ||
0.0 | ||
}; | ||
|
Uh oh!
There was an error while loading. Please reload this page.