Skip to content

Type-erased Specializers #20391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Type-erased Specializers #20391

wants to merge 2 commits into from
+137 −3

Conversation

ecoskey
Copy link
Contributor

@ecoskey ecoskey commented Aug 3, 2025 •
edited
Loading

Add type-erased wrappers around Specializer and SpecializerKey

Currently, type-erased materials have their key type and key getter located in AsBindGroup, and their specialize fn located in Material. This is mostly an experiment, but I think erased specializers might be a good way to wrap all that logic up nicely.

Currently there's more boxing than there should be, I'll probably switch to some form of bytemuck or SmallBox later

blocked on #20348

@ecoskey ecoskey added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen S-Blocked This cannot move forward until something else changes D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels Aug 3, 2025
@ecoskey ecoskey added S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Blocked This cannot move forward until something else changes S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 13, 2025
@ecoskey ecoskey added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Oct 1, 2025
alice-i-cecile
alice-i-cecile requested changes Oct 1, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a migration guide :)

@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Oct 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

@ecoskey

This comment was marked as resolved.

Sign in to view
@alice-i-cecile alice-i-cecile self-requested a review October 1, 2025 19:25
alice-i-cecile
alice-i-cecile reviewed Oct 1, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration guide looks fine, but I don't have the rendering chops to review this further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ecoskey @alice-i-cecile