Skip to content

Make bevy_animation not depend on bevy_render #20472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Aug 9, 2025
Merged

Make bevy_animation not depend on bevy_render #20472

alice-i-cecile merged 1 commit into from
Aug 9, 2025

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Aug 9, 2025

Objective

  • recognize this holy gift and celebrate this chance to be alive and breathing 30% more this fall by not waiting for bevy_render to compile when you use bevy_animation

Solution

  • use a SystemSet to decouple a system ordering dependency

Testing

  • cargo check --examples

@james7132 james7132 added A-Rendering Drawing game state to the screen A-Animation Make things move and change over time labels Aug 9, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Aug 9, 2025
@james7132 james7132 added C-Dependencies A change to the crates that Bevy depends on C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 9, 2025
@atlv24
Copy link
Contributor Author

atlv24 commented Aug 9, 2025

Related: #18465
this PR is simpler, that PR is faster but has breaking changes.

@greeble-dev
Copy link
Contributor

greeble-dev commented Aug 9, 2025

(Re-posting from Discord) Re #18465, I think it's fine for this PR to land first as the simpler and safer change. I'll fixup #18465 afterwards.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 9, 2025
Merged via the queue into bevyengine:main with commit 1c829a6 Aug 9, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Aug 9, 2025
This was referenced Aug 10, 2025
Closed
Open
@atlv24 atlv24 deleted the ad/renderless-animation branch August 10, 2025 20:21
gwafotapa pushed a commit to gwafotapa/bevy that referenced this pull request Aug 12, 2025
@atlv24 @gwafotapa
Make bevy_animation not depend on bevy_render (bevyengine#20472)
d4948b6 
# Objective

- recognize this holy gift and celebrate this chance to be alive and
breathing 30% more this fall by not waiting for bevy_render to compile
when you use bevy_animation

## Solution

- use a SystemSet to decouple a system ordering dependency

## Testing

- cargo check --examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

+1 more reviewer

@Zeophlite Zeophlite Zeophlite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Animation Make things move and change over time A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.17

Development

Successfully merging this pull request may close these issues.

5 participants

@atlv24 @greeble-dev @Zeophlite @james7132 @alice-i-cecile