[Merged by Bors] - [bevy_derive] Refactor modules for better error message. #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
force-pushed
the
nward/bevy-derive-modules-refactor
branch
2 times, most recently
from
daa36ff to
866fa62
Compare
alice-i-cecile
added
the
C-Code-Quality
bjorn3
reviewed
Apr 30, 2021
crates/bevy_derive/src/modules.rs
Outdated
| } | ||
| Manifest::new() | ||
| .unwrap() | ||
| .find(|name| name == "bevy" || name == "bevy_internal") |
There was a problem hiding this comment.
This makes the output of this function depend on the order of dependencies if both bevy and bevy_internal are specified as dependencies for some reason.
There was a problem hiding this comment.
yes true, though this was the previous behavior of the implementation IIUC?
Edit: oh, now I understand what you mean!
Problem: - When using the 'as_crate' attribute, if 'as_crate' was empty, the only error you would get is 'integer underflow'. Solution: - Provide an explicit check for the 'as_crate' attribute's token stream to ensure the formatting is correct.
NathanSWard
force-pushed
the
nward/bevy-derive-modules-refactor
branch
from
866fa62 to
7d41785
Compare
mockersf
approved these changes
May 1, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
As a heads up: this will conflict with #1875. |
|
Merging this because its ready now :) |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 6, 2021
Problem: - When using the 'as_crate' attribute, if 'as_crate' was empty, the only error you would get is 'integer underflow'. Solution: - Provide an explicit check for the 'as_crate' attribute's token stream to ensure the formatting is correct. Note: - Also reworked 'get_meta' by not making it call 'Manifest::find' twice.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
…2059) Problem: - When using the 'as_crate' attribute, if 'as_crate' was empty, the only error you would get is 'integer underflow'. Solution: - Provide an explicit check for the 'as_crate' attribute's token stream to ensure the formatting is correct. Note: - Also reworked 'get_meta' by not making it call 'Manifest::find' twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
error you would get is 'integer underflow'.
Solution:
to ensure the formatting is correct.
Note: