-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clippy support and fix all warnings / errors #206
Conversation
This one will take a bit more time for me to review. I havent used clippy much in practice so I need to sort out what I want from it. |
to determine the urgency of this pr: were these changes all automated or did you need manual intervention? if its automated im fine waiting, but i dont want to throw away a bunch of manual work / make it hard to update this pr when we merge new stuff. |
clippy can't automatically fix the vast majority of suggestions by itself yet, so I had to do it by hand. It isn't perfect, but it doesn't let the kind of code one writes at 4am through |
I learned a few new patterns from this pr. Nice! This looks good to go. |
Depends on #204 and #201