Skip to content

Add release notes for new Sun Disk feature #21153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2025
Merged

Add release notes for new Sun Disk feature #21153

merged 3 commits into from
Sep 21, 2025
+25 −0

Conversation

@alice-i-cecile
Copy link
Member

Objective

Solution

  • Write release notes.
  • Also add a note to the docs that this plays nicely with bloom.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 21, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Sep 21, 2025
@alice-i-cecile
Copy link
Member Author

@defuz, as the feature author I'd appreciate your review on this to make sure I've explained it well :)

alice-i-cecile
alice-i-cecile commented Sep 21, 2025
View reviewed changes
crates/bevy_light/src/directional_light.rs
/// disk entirely with [`SunDisk::OFF`].
///
/// In order to cause the sun to "glow" and light up the surrounding sky, enable bloom
/// in your post-processing pipeline by adding a `Bloom` component to your camera.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't make this a doc-link because there's no dependency between bevy_light and bevy_post_process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what we sometimes do is link the website docs instead in this case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, which I don't hate, but IMO this is easy to search for end users.

alice-i-cecile
alice-i-cecile commented Sep 21, 2025
View reviewed changes
ecoskey
ecoskey approved these changes Sep 21, 2025
View reviewed changes
@alice-i-cecile @ecoskey
Simplify bloom wording
79de6e6 
Co-authored-by: Emerson Coskey <emerson@coskey.dev>
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 21, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 21, 2025
Merged via the queue into bevyengine:main with commit 9ac1bb1 Sep 21, 2025
35 checks passed
mockersf pushed a commit that referenced this pull request Sep 21, 2025
@alice-i-cecile @ecoskey @mockersf
Add release notes for new Sun Disk feature (#21153)
a44ad73 
# Objective

- #20434 is really cool, and deserves a bit of a showcase.
- Fixes #21125.

## Solution

- Write release notes.
- Also add a note to the docs that this plays nicely with bloom.

---------

Co-authored-by: Emerson Coskey <emerson@coskey.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janhohenheim janhohenheim Awaiting requested review from janhohenheim

@cart cart Awaiting requested review from cart

@mate-h mate-h Awaiting requested review from mate-h

2 more reviewers

@atlv24 atlv24 atlv24 left review comments

@ecoskey ecoskey ecoskey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.17

Development

Successfully merging this pull request may close these issues.

Add release notes for bevy_light::SunDisk

3 participants

@alice-i-cecile @atlv24 @ecoskey