Skip to content

Revived #18741, Remove SimpleExecutor. #21176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2025
Merged

Revived #18741, Remove SimpleExecutor. #21176

merged 4 commits into from
Sep 22, 2025

Conversation

ElliottjPierce
Copy link
Contributor

Objective

Revive #18741 :

Reduce complexity and code duplication of schedule executors. This is an alternative to fix #18453.

It sounds like SimpleExecutor was a temporary solution to "sync points" in schedules, but now those can be inferred, so SimpleExecutor is unnecessary now.

Further, SimpleExecutor and SingleThreadedExecutor were very similar, which was becoming a consistency and code quality headache.

Solution

Remove SimpleExecutor.

Testing

CI

@ElliottjPierce ElliottjPierce added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events X-Controversial There is active debate or serious implications around merging this PR S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 22, 2025
@ElliottjPierce ElliottjPierce added this to the 0.18 milestone Sep 22, 2025
@ElliottjPierce ElliottjPierce mentioned this pull request Sep 22, 2025
Closed
@alice-i-cecile alice-i-cecile added S-Needs-SME Decision or review from an SME is required and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 22, 2025
@james7132 james7132 removed the S-Needs-SME Decision or review from an SME is required label Sep 22, 2025
@james7132 james7132 enabled auto-merge September 22, 2025 23:21
@james7132 james7132 added this pull request to the merge queue Sep 22, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers and removed X-Controversial There is active debate or serious implications around merging this PR labels Sep 22, 2025
Merged via the queue into bevyengine:main with commit 12f802b Sep 22, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

Increase structure for schedule executors to reduce boilerplate and ensure consistency

3 participants

@ElliottjPierce @james7132 @alice-i-cecile