Remove Internal component
#21623
Merged
Remove Internal component
#21623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
alice-i-cecile
added
the
S-Waiting-on-Author
cart
approved these changes
Oct 21, 2025
cart
approved these changes
Oct 21, 2025
alice-i-cecile
added
S-Needs-Review
janis-bhm
reviewed
Oct 21, 2025
| pub fn despawn_entities_on_exit_state<S: States>( | ||
| mut commands: Commands, | ||
| mut transitions: MessageReader<StateTransitionEvent<S>>, | ||
| // TODO: Use `AllowAll` once it exists: https://github.com/bevyengine/bevy/issues/21615 |
There was a problem hiding this comment.
Why was this todo removed? reading the related issue/PR, it sounds like the intent to completely bypass the default query filters here once that becomes possible to express in a system remains.
There was a problem hiding this comment.
I don't think that we should be using AllowAll here even after #21615 is implemented. The behavior is too surprising and will mess with people's e.g. prefab systems that are built using disabling components.
janis-bhm
approved these changes
Oct 21, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
|
This should also close #21363, since |
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
# Objective Despite initially advocating for its inclusion in bevyengine#20204, I've been increasingly unconvinced by the edge cases and user-facing complexity and surprise that `Internal` brings. Accidental queries are quite hard to write, and the entitiy-inspector concerns are really a UX problem for each tool to solve that `Internal` doesn't help with. @cart feels similarly: as a result I'm marking this PR as X-Blessed. Closes bevyengine#21363. ## Solution - Remove `Internal` as a type. - Follow the compiler errors to remove all references. - Write a migration guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Despite initially advocating for its inclusion in #20204, I've been increasingly unconvinced by the edge cases and user-facing complexity and surprise that
Internalbrings.Accidental queries are quite hard to write, and the entitiy-inspector concerns are really a UX problem for each tool to solve that
Internaldoesn't help with.@cart feels similarly: as a result I'm marking this PR as X-Blessed.
Closes #21363.
Solution
Internalas a type.