Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Improve legibility of RunOnce::run_unsafe param #2181

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Improve legibility of RunOnce::run_unsafe param #2181

wants to merge 1 commit into from

Conversation

Nilirad
Copy link
Contributor

@Nilirad Nilirad commented May 16, 2021

During PR #2046 @cart suggested that the (): () notation is less legible than _input: (). The first notation still managed to slip in though. This PR applies the second writing.

@mockersf mockersf added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-ECS Entities, components, systems, and events labels May 16, 2021
@NathanSWard
Copy link
Contributor

Side note, these are my favorite PRs to review. Simple, useful, and concise <3

@NathanSWard
Copy link
Contributor

Also as a quick note, this will need to be rebased on top of main to fix the CI failures.

@cart
Copy link
Member

cart commented May 17, 2021

bors can handle this for us. Lets give it a try!

@cart
Copy link
Member

cart commented May 17, 2021

bors r+

bors bot pushed a commit that referenced this pull request May 18, 2021
@Nilirad
Improve legibility of RunOnce::run_unsafe param (#2181)
1f0988b 
During PR #2046 @cart suggested that the `(): ()` notation is less legible than `_input: ()`. The first notation still managed to slip in though. This PR applies the second writing.
@bors
Copy link
Contributor

bors bot commented May 18, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Improve legibility of RunOnce::run_unsafe param [Merged by Bors] - Improve legibility of RunOnce::run_unsafe param May 18, 2021
@bors bors bot closed this May 18, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@Nilirad @ostwilkens
Improve legibility of RunOnce::run_unsafe param (bevyengine#2181)
d53767a 
During PR bevyengine#2046 @cart suggested that the `(): ()` notation is less legible than `_input: ()`. The first notation still managed to slip in though. This PR applies the second writing.
@Nilirad Nilirad deleted the run-once-legibility branch December 5, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nilirad @NathanSWard @cart @mockersf @bjorn3