-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Parallel Mesh Collection #22297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aevyrie
wants to merge
22
commits into
bevyengine:main
Choose a base branch
from
aevyrie:par-mesh-collection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+559
−149
Open
Parallel Mesh Collection #22297
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6aafecb
Channel-based mesh collection and prep.
aevyrie 1ba8491
Tweak chunk size
aevyrie 3eba77c
Revert toml formatter changes
aevyrie a2cfded
Fix bug in mesh material indexing
aevyrie cd40ac6
fix clippy lints
aevyrie d360eb9
more lints
aevyrie 8e4780f
reduce diff
aevyrie 860d3cf
better handle mesh re-extraction, fix single threaded deadlock, impro…
aevyrie 8917e4d
Fix doc links
aevyrie 04de8fc
Merge branch 'main' into par-mesh-collection
aevyrie 6f785cb
Tune chunk size
aevyrie eca0c30
Refactor order and comments for readability
aevyrie d1cd1e5
Refactor buffered channel logic into a struct.
aevyrie 7735924
Async buffered channel
aevyrie 9d8680a
Correctly instrument async closure, add doc comments to gpu struct
aevyrie fa4f1d3
fmt
aevyrie 7b2e3cb
Consolidate block_on impl to fix WASM build error
aevyrie 716e632
Remove unnecessary qualification
aevyrie 809bc66
Fix doc link
aevyrie 69f235e
Fix vecs not being reused when consumed by intoiterator
aevyrie 23c8f08
Merge branch 'main' into par-mesh-collection
aevyrie a3aa5a7
Merge branch 'main' into par-mesh-collection
aevyrie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aevyrie marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| //! Platform-aware future utilities. | ||
|
|
||
| crate::cfg::switch! { | ||
| #[cfg(feature = "async-io")] => { | ||
| pub use async_io::block_on; | ||
| } | ||
| #[cfg(feature = "futures-lite")] => { | ||
| pub use futures_lite::future::block_on; | ||
| } | ||
| _ => { | ||
| /// Blocks on the supplied `future`. | ||
| /// This implementation will busy-wait until it is completed. | ||
| /// Consider enabling the `async-io` or `futures-lite` features. | ||
| pub fn block_on<T>(future: impl Future<Output = T>) -> T { | ||
| use core::task::{Poll, Context}; | ||
|
|
||
| // Pin the future on the stack. | ||
| let mut future = core::pin::pin!(future); | ||
|
|
||
| // We don't care about the waker as we're just going to poll as fast as possible. | ||
| let cx = &mut Context::from_waker(core::task::Waker::noop()); | ||
|
|
||
| // Keep polling until the future is ready. | ||
| loop { | ||
| match future.as_mut().poll(cx) { | ||
| Poll::Ready(output) => return output, | ||
| Poll::Pending => core::hint::spin_loop(), | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.