Improve code examples in 0.18 migration guides #22364
Conversation
My general goal was to make these examples more consistent, using `// 0.17` rather than `// Before`, avoiding diff blocks, and using `// ...` rather than `todo!()`.
…he main `bevy` crate
BD103
added
C-Docs
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
Nothing I did in this PR affects rendering, so I bet this check is comparing my branch to |
it-me-joda
left a comment
it-me-joda
left a comment
There was a problem hiding this comment.
I agree that this is more concise and readable. I think I only found one typo.
alice-i-cecile
added
S-Ready-For-Final-Review
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
3 participants
Important
This PR targets the
release-0.18.0branch, notmain.Objective
Solution
bevy_input's input-type features (keyboard,gamepad, etc.) are also available on the mainbevycrate.Testing
I tested that the system combinator migration guide code examples worked in the relevant versions, but didn't test any of the others because I didn't modify any of their actual code.