-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add warning log for sprite picking failure on compressed textures #22414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hm this requires adding bevy_log dep to bevy_sprite, dunno if thats acceptable ? |
JMS55
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one nit. Adding bevy_log dep is fine.
|
im getting this warn even when not using compressed assets because of another problem |
|
Ping me when this is ready for review and I'll take a look :) |
933c5ea to
5e0f22e
Compare
|
@alice-i-cecile ready, this is much better now :) |
Objective
fixes #22413
from this issue:
its very hard to debug why a sprite picking doesn't work when encountering this issue, i think a warn is really useful.
Solution
add a warn! log
Testing
tested on my own project
is the log message adapted ?
thanks